Implement rocSOLVER dsyevd for MAGMA build #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suemni
approved these changes
Mar 7, 2022
cnegre
approved these changes
Mar 7, 2022
nicolasbock
approved these changes
Mar 7, 2022
jeanlucf22
requested changes
Mar 7, 2022
CMakeLists.txt
Outdated
| @@ -253,6 +253,35 @@ if (CUDA_FOUND) | |||
| include_directories(${CUDA_INCLUDE_DIRS}) | |||
| endif() | |||
|
|
|||
| list(APPEND CMAKE_PREFIX_PATH $ENV{ROCM_PATH}) | |||
There was a problem hiding this comment.
Shouldn't it be done in the build script instead of here?
CMakeLists.txt
Outdated
| endif() | ||
|
|
||
| if(BML_ROCSOLVER) | ||
| find_package(rocblas) |
There was a problem hiding this comment.
Should REQUIRED be added as an argument here? Build should fail if the roc solver is requested but rocblas is not found, right?
CMakeLists.txt
Outdated
| @@ -454,6 +492,9 @@ if(MAGMA_FOUND) | |||
| if(BML_CUSOLVER) | |||
| list(APPEND LINK_LIBRARIES ${CUDA_cusolver_LIBRARY}) | |||
| endif() | |||
| if(BML_ROCSOLVER) | |||
| list(APPEND LINK_LIBRARIES ${ROCM_rocsolver_LIBRARY}) | |||
There was a problem hiding this comment.
rocsolver_LIBRARIES is used earlier. Is it the same as ROCM_ro?csolver_LIBRARIES
There was a problem hiding this comment.
I just pushed a revision. Are these comments addressed?
|
@mewall Did you verify that none of your additions conflict with the magma build on NVIDIA? |
o Pattern after cuSOLVER implementation
o Build is controlled using BML_ROCSOLVER
- Like BML_CUSOLVER
jeanlucf22
approved these changes
Mar 7, 2022
|
I built on summit using BML_CUSOLVER. There doesn't appear to be any conflict with the NVIDIA MAGMA build. However, some other tests are failing on summit. I'll create an issue.
…________________________________
From: Jean-Luc Fattebert ***@***.***>
Sent: Monday, March 7, 2022 9:05:46 AM
To: lanl/bml
Cc: Wall, Michael E; Mention
Subject: [EXTERNAL] Re: [lanl/bml] Implement rocSOLVER dsyevd for MAGMA build (PR #597)
@mewall<https://github.com/mewall> Did you verify that none of your additions conflict with the magma build on NVIDIA?
—
Reply to this email directly, view it on GitHub<#597 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AA67VELGQDSC6NUSAB2K4YTU6YSNVANCNFSM5QDVWXTQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
o Pattern after cuSOLVER implementation
o Build is controlled using BML_ROCSOLVER
- Like BML_CUSOLVER