Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bml_get_deep_type function #551

Merged
merged 1 commit into from
Oct 15, 2021
Merged

Add bml_get_deep_type function #551

merged 1 commit into from
Oct 15, 2021

Conversation

jeanlucf22
Copy link
Collaborator

No description provided.

nicolasbock
nicolasbock requested changes Oct 13, 2021
View reviewed changes
Copy link
Collaborator

@nicolasbock nicolasbock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test for this new function? You could test whether the function returns the correct type in case the library was compiled with MPI and whether it correctly defaults back to the non-deep function in case there is no MPI support.

src/C-interface/bml_introspection.c Show resolved Hide resolved
nicolasbock
nicolasbock approved these changes Oct 15, 2021
View reviewed changes
Copy link
Collaborator

@nicolasbock nicolasbock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jeanlucf22

@nicolasbock nicolasbock merged commit 1a48d91 into lanl:master Oct 15, 2021
@jeanlucf22 jeanlucf22 deleted the get_deep_type branch February 9, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnegre cnegre cnegre approved these changes

@suemni suemni suemni approved these changes

@nicolasbock nicolasbock nicolasbock approved these changes

@jmohdyusof jmohdyusof Awaiting requested review from jmohdyusof jmohdyusof is a code owner

@tokshgithub tokshgithub Awaiting requested review from tokshgithub tokshgithub is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeanlucf22 @nicolasbock @suemni @cnegre