Add CUDA libraries when linking if CUDA is found by cmake

[mewall]

No description provided.

[jmohdyusof]

Still curious if manually appending to the list or using a function like include_directories() is preferred.

[nicolasbock]

The function include_directories() adds to the list of includes, i.e. is used for header files. The LINK_LIBRARIES variable tracks part of the linker flags. Both would be needed to add a library.

But as @mewall points out, the FindCUDA module is deprecated since CMake 3.10. Since we are requiring at least that version it's safe to drop the code around the FindCUDA module and replace it with listing CUDA as a compiler language at the top of the CMakeLists.txt file.

[nicolasbock]

It is cleaner to just remove the FindCUDA module and all of the logic that goes with it and replace it with listing CUDA as a language at the top.

[mewall]

I just checked, simply adding CUDA as a language doesn't add the CUDA include path at compile time, at least in my hands. I can't work on this more now but I did create an issue for it already. Maybe accept the latest PR and work on this later? The new PR just changes one line of code in CMakeLists.txt compared to commit 27295f9.

…

________________________________ From: Nicolas Bock ***@***.***> Sent: Wednesday, October 6, 2021 12:24:35 PM To: lanl/bml Cc: Wall, Michael E; Mention Subject: [EXTERNAL] Re: [lanl/bml] Add CUDA libraries when linking if CUDA is found by cmake (#545) @nicolasbock requested changes on this pull request. It is cleaner to just remove the FindCUDA module and all of the logic that goes with it and replace it with listing CUDA as a language at the top. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#545 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AA67VENWS2DB342F7VW6Z2LUFSH6HANCNFSM5FPJDNMA>.

[jmohdyusof]

@nicolasbock What I was trying to say was that maybe there should be a link_directories() function that adds to the link_libraries. It seems incongruous to use two different methods to do very similar things (since the include_directories should also append to some list of include paths)

[nicolasbock]

Actually there is target_link_libraries which looks like it is exactly what you were thinking of @jmohdyusof . I can't remember why we don't use that call to be honest. It looks a lot cleaner than adding to LINK_LIBRARIES directly 😄

[nicolasbock]

rebased