Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed README file #406

Merged
merged 4 commits into from
Sep 10, 2020
Merged

Changed README file #406

merged 4 commits into from
Sep 10, 2020

Conversation

cnegre
Copy link
Collaborator

@cnegre cnegre commented Sep 9, 2020 •
edited by nicolasbock
Loading

Updated README

This change is Reviewable

@cnegre cnegre requested a review from jeanlucf22 September 9, 2020 20:41
@nicolasbock
Copy link
Collaborator

nicolasbock commented Sep 9, 2020 •
edited
Loading

Danger has errored

[!] Invalid Dangerfile file: undefined method each for nil:NilClass. Updating the Danger gem might fix the issue. Your Danger version: 7.0.1, latest Danger version: 8.0.5

 #  from Dangerfile:18
 #  -------------------------------------------
 #  # reviewers.
 >  mention.run(2, [], [])
 #  
 #  -------------------------------------------

Generated by 🚫 Danger

@coveralls
Copy link

coveralls commented Sep 9, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 66.532% when pulling c076943 on README-update into 7cb1ce7 on master.

@codecov
Copy link

codecov bot commented Sep 9, 2020 •
edited
Loading

Codecov Report

Merging #406 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #406   +/-   ##
======================================
  Coverage      64%     64%           
======================================
  Files         340     340           
  Lines       15034   15034           
  Branches     1212    1212           
======================================
  Hits         9766    9766           
  Misses       4961    4961           
  Partials      307     307

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cb1ce7...c076943. Read the comment docs.

@jeanlucf22
Copy link
Collaborator

Please add myself and @oseikuffuor1 as contributors

@jeanlucf22
Copy link
Collaborator

Shall we add reference to BML 2018 paper?

nicolasbock
nicolasbock approved these changes Sep 10, 2020
View reviewed changes
Copy link
Collaborator

@nicolasbock nicolasbock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nicolasbock nicolasbock merged commit 190ee05 into master Sep 10, 2020
@nicolasbock nicolasbock deleted the README-update branch September 10, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suemni suemni suemni approved these changes

@nicolasbock nicolasbock nicolasbock approved these changes

@jeanlucf22 jeanlucf22 Awaiting requested review from jeanlucf22 jeanlucf22 is a code owner

@tokshgithub tokshgithub Awaiting requested review from tokshgithub tokshgithub is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cnegre @nicolasbock @coveralls @jeanlucf22 @suemni