Update bml_allocate.c #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnegre
approved these changes
Apr 30, 2020
nicolasbock
requested changes
Apr 30, 2020
src/C-interface/bml_allocate.c
Outdated
| @@ -54,6 +54,7 @@ bml_allocate_memory( | |||
| #elif defined(HAVE_POSIX_MEMALIGN) | |||
| char *ptr; | |||
| posix_memalign((void **) &ptr, MALLOC_ALIGNMENT, size); | |||
| #pragma omp parallel for simd | |||
There was a problem hiding this comment.
I think the change is fine, however, this raises the compiler requirement to OpenMP >= 4.0, which means gcc >= 4.9. Right now we are still testing with gcc-4.7. In terms of Ubuntu this excludes only Trusty (14.04) which is probably not a big issue.
|
This PR is stale because it has been open for 90 days with no activity. |
51d6d2b to
67b216a
Compare
67b216a to
aa8e2db
Compare
Modified HAVE_POSIX_MEMALIGN macro for first touch. Signed-off-by: Nicolas Bock <nicolasbock@gmail.com>
aa8e2db to
eb83935
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modified HAVE_POSIX_MEMALIGN macro for first touch
This change is