Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with shared libs #70

Open
wants to merge 274 commits into
base: master
Choose a base branch
from
Open

Build with shared libs #70

wants to merge 274 commits into from

Conversation

junghans
Copy link
Member

Build with shared libs is broken!

@nicolasbock do you know why?

cawkwell and others added 30 commits March 16, 2017 16:24
Added virial components as argument of the latte_lib
… available from MJC and will be uploaded to ECP sites
added call flush and compiling lines
…o enable static compilation. Both LATTE objects and gfortran libraries will be included inside the final binary. Binary size changes from 900K to 2.8M.
cnegre and others added 12 commits June 25, 2018 18:06
…orthogonal basis and with k-space integration. Useful for metals or when charge sloshing is occurring. Set ELECTRO = 0 to use
…orthogonal basis and with k-space integration. Useful for metals or when charge sloshing is occurring. Set ELECTRO = 0 to use
…ving the divide-and-conquer diagonalizer on by default. A failsafe for DSYEVD has been added to the diagonalization calls in diagmyh.f90 and genX.f90 too.
…ving the divide-and-conquer diagonalizer on by default. A failsafe for DSYEVD has been added to the diagonalization calls in diagmyh.f90 and genX.f90 too.
* .travis.yml: fix exit for cmake build

* cmake: add missing files

* FindBML.cmake: search bml_fortran

* add .codecov.yml
* .travis.yml: fix exit for cmake build

* cmake: add missing files

* FindBML.cmake: search bml_fortran

* add .codecov.yml
@junghans
Copy link
Member Author

The problem is actually in progress:

[100%] Linking Fortran executable ../main
../src/libprogress.so: undefined reference to `bml_convert_from_dense_'
../src/libprogress.so: undefined reference to `mmult_'
../src/libprogress.so: undefined reference to `bml_convert_to_dense_'
../src/libprogress.so: undefined reference to `ewald_real_space_'
../src/libprogress.so: undefined reference to `get_deriv_finite_temp_'
../src/libprogress.so: undefined reference to `inv_'
../src/libprogress.so: undefined reference to `eig_'
../src/libprogress.so: undefined reference to `ewald_k_space_'

@nicolasbock
Copy link
Collaborator

Yes, we need to clean it up a bit. One reason our CI didn't detect this issue is because we test progress against the Ubuntu package of the bml and not from source. There are other calls though that are incorrect in progress. I am going to post PRs to fix.

nicolasbock added a commit to nicolasbock/qmd-progress that referenced this pull request Jul 1, 2018
We should test progress with upstream bml and not from Ubuntu
package. The package tests are better run on the Ubuntu or OpenSUSE
build infrastructure.

Bug: lanl/LATTE#70
nicolasbock added a commit to nicolasbock/qmd-progress that referenced this pull request Jul 2, 2018
We should test progress with upstream bml and not from Ubuntu
package. The package tests are better run on the Ubuntu or OpenSUSE
build infrastructure.

Bug: lanl/LATTE#70
cnegre and others added 3 commits July 2, 2018 17:18
* New  Pulay forces terms for local charge neutrality

* Input files etc. for the tabulated integrals. Example for W metal

* W supercell for testing

* New makefile with default divide and conquer diagonalizer

* Updated subroutines so we can use either the analytic (SCLTYPE= EXP) or tabulated (SCLTYPE= TABLE) forms for the bond and overlap integrals.

* Input files etc. for the tabulated integrals. Example for W metal

* W supercell for testing

* New makefile with default divide and conquer diagonalizer

* Updated subroutines so we can use either the analytic (SCLTYPE= EXP) or tabulated (SCLTYPE= TABLE) forms for the bond and overlap integrals.

* Changed tests for compatibility with tableread

* fixed bug

* Fixed cmake

* no cmake

* Added compilations instructions in the README file

* Added compilations instructions in the README file

* Added compilations instructions in the README file
* New  Pulay forces terms for local charge neutrality

* Input files etc. for the tabulated integrals. Example for W metal

* W supercell for testing

* New makefile with default divide and conquer diagonalizer

* Updated subroutines so we can use either the analytic (SCLTYPE= EXP) or tabulated (SCLTYPE= TABLE) forms for the bond and overlap integrals.

* Input files etc. for the tabulated integrals. Example for W metal

* W supercell for testing

* New makefile with default divide and conquer diagonalizer

* Updated subroutines so we can use either the analytic (SCLTYPE= EXP) or tabulated (SCLTYPE= TABLE) forms for the bond and overlap integrals.

* Changed tests for compatibility with tableread

* fixed bug

* Fixed cmake

* no cmake

* Added compilations instructions in the README file

* Added compilations instructions in the README file

* Added compilations instructions in the README file
junghans and others added 2 commits July 3, 2018 10:51
* .travis.yml: fix lammps build with cmake

* .travis.yml: re-enable CMake build

* README.md: added cmake section (fix lanl#73)
@codecov
Copy link

codecov bot commented Jul 3, 2018

Codecov Report

Merging #70 into master will increase coverage by <.1%.
The diff coverage is 63.6%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #70     +/-   ##
========================================
+ Coverage    47.9%     48%   +<.1%     
========================================
  Files         198     198             
  Lines       16108   16055     -53     
========================================
- Hits         7730    7716     -14     
+ Misses       8378    8339     -39
Impacted Files Coverage Δ
src/solvematcg.f90 0% <ø> (ø) ⬆️
src/tbmd.f90 66.4% <ø> (ø) ⬆️
src/sp2T.f90 0% <ø> (ø) ⬆️
src/kdeorthomyrho.f90 100% <ø> (ø) ⬆️
src/orthomyHprogress.f90 85.7% <ø> (ø) ⬆️
src/dfda.f90 100% <ø> (ø) ⬆️
src/norms.f90 0% <ø> (ø) ⬆️
src/timer_mod.f90 100% <ø> (ø) ⬆️
src/sp2pure_sparse.f90 0% <ø> (ø) ⬆️
src/readppotspline.f90 0% <ø> (ø) ⬆️
... and 249 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ac131b...5bd3afc. Read the comment docs.

@nfaguirrec nfaguirrec force-pushed the master branch 4 times, most recently from c7cad60 to 61223bb Compare July 4, 2018 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants