Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Add RAVENS schema #472

Draft
wants to merge 36 commits into
base: main
Choose a base branch
from
Draft

WIP: Add RAVENS schema #472

wants to merge 36 commits into from

Conversation

juanjospina
Copy link
Contributor

This is is still a Work in Progress (WIP) branch.

The parser can be (temporary) tested using the following:

pmd_file = "../file.json"

# parse JSON file
pmd_data = parse_file(pmd_file)

# instantiate model
pmd_model = instantiate_mc_model_ravens(pmd_data, ACPUPowerModel, build_mc_opf)

result = optimize_model!(
        pmd_model,
        relax_integrality=false,
        optimizer=ipopt,
        solution_processors=Function[]
    )

@juanjospina
WIP: ravens to math converter for PMD.
dadefbe
@juanjospina
WIP: add bases to certain elements - debugging changes
542f3dd
@juanjospina
WIP: revise case3 ravens to math model code.
b5dea97
@juanjospina
WIP: case3 balanced working. Still missing transformers, shunts, gene…
d616a1e 
…rators, solar, and storage.
@juanjospina
Revise ravens schema (#2)
15d72f8 
* REF: revise and refactor ravens2math functions to simplify them.

* FIX: issues with dictionary access in ravens funcs.
@juanjospina
ADD: generator or rotating machine parser for ravens2math
bbfa2d7
@juanjospina
ADD: pv or photovoltaic unit parser for ravens2math.
03a55d4
@juanjospina
ADD: storage or battery unit parser for ravens2math
05f483e
@juanjospina
REF: combined PVs and Battery Units in Ravens parser to avoid multipl…
1021d87 
…e loops through PowerElectronicsConnection.
@juanjospina
REF: ravens2math parser to fix impedance calculations and support fil…
d7559d7 
…es coming from dss-xml-json ravens exporters.
@juanjospina
REF: add haskey check when looking for gens and power electronics
e7b082c
@juanjospina
WIP: Switches - still missing connection to virtual bus and branches.
8bb608d
@juanjospina
REF: OperationalLimitType parsing with new style.
248210b
@juanjospina
FIX: storage ravens2math parser.
dda9e4a
@juanjospina
REF: a function that extracts the name of a ravens string.
a5d54a4
@juanjospina
REF: replace SvStatus with Equipment.inService
2fb384d
@juanjospina
FIX: charge and discharge on BatteryUnit.
b54fbc5
@juanjospina
WIP: Add Parser for PowerTransformer based on PowerTransformerEnd. Er…
8ee4faa 
…rors still exist.
@juanjospina
WIP: debig powertransformer issues related to terminals and bus_type …
f6698b9 
…coming from build_loss
@juanjospina
FIX: powertransformer issue related to fnode when creating virtual br…
86f3f47 
…anches.
@juanjospina
REF: phasecode in transformers.
8726941
@juanjospina
ADD: ShuntCompensator ravens parser.
4688964
@juanjospina juanjospina marked this pull request as draft October 14, 2024 19:33
@juanjospina
FIX: issues to be able to run test case with switches.
5f89b05
@juanjospina
REF: ravens2math by removing if statements and using phasecode map in…
6aa181d 
… utils ravens.
@juanjospina
REF: ravens2math to reduce if levels.
e04a1f0
@juanjospina
ADD: unit tests for ravens parser.
86fa5be
@juanjospina
ADD: support for basic multinetwork functionality using RAVENS schema…
70b5b74 
… based on BasicIntervalSchedule.
@juanjospina
ADD: TransformerTank support and minor modeling fixes (#3)
ba64f3b 
* WIP: TransformerTanks support. Adding them individually connected to the same fbus is giving errors.

* WIP: new version of TransformerTank. Plus - Important Fixes to Conductors, Switches, and EnergySource.

* REF: TransformerTanks but as Single-Phase entities.

* REF: TransformerTanks per single phase to avoid extra winding/tank loop.

* FIX: resistance and reactance for Transformers computations - single-phase

* REF: configuration and polarity of transformers based on connections DELTA-WYE, etc.

* REF: PowerTransformerEnd to avoid unnecessary calculations and clean code.

* REF: TransformerTank parsing.

* ADD: feature to combine TransformerTanks into a single transformer mathematical representation.
@juanjospina
RM: print out statements for debugging.
589ef50
@codecov Codecov
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 62.47113% with 325 lines in your changes missing coverage. Please review.

Project coverage is 73.38%. Comparing base (80d6178) to head (c979b5b).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
src/data_model/transformations/ravens2math.jl 60.12% 325 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #472      +/-   ##
==========================================
- Coverage   75.01%   73.38%   -1.63%     
==========================================
  Files          73       74       +1     
  Lines       16541    17258     +717     
==========================================
+ Hits        12408    12665     +257     
- Misses       4133     4593     +460

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@juanjospina