-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compute the susceptance matrix in higher precision #863
Conversation
Codecov Report
@@ Coverage Diff @@
## master #863 +/- ##
=======================================
Coverage 93.79% 93.79%
=======================================
Files 43 43
Lines 9893 9893
=======================================
Hits 9279 9279
Misses 614 614
Continue to review full report in Codecov by Sentry.
|
@ccoffrin so it looks like PowerModels is veeeeery sensitive to |
I spoke too soon. Previous commit passed though... |
Thanks a bunch for digging into this. Now that I understand the root cause, I am inclined to relax the test requirements rather than update these operations to If you have any insights into what Julia functions provide the best abstractions for processing Complex numbers (e.g, |
1 / x didn't fix it, which I guess isn't surprising. Should the susceptance matrix always have a det of 0? It seems problematic if an imprecision of |
You are right, using |
What about just checking the smallest absolute eigen value? |
Closing in favor of #865 |
Closes #862