Fix Parser for HVDC lines with PWL Costs #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #317 +/- ##
==========================================
+ Coverage 97.89% 97.96% +0.06%
==========================================
Files 46 46
Lines 5851 5852 +1
==========================================
+ Hits 5728 5733 +5
+ Misses 123 119 -4
Continue to review full report at Codecov.
|
Merged
ccoffrin
pushed a commit
that referenced
this pull request
Oct 12, 2018
* prepare changelog for next release * remove redefinition of InfrastructureModels.ismultinetwork * Discrepancy BIM vs BFM (#286) * found for discrepancy SOC BFM vs BIM * Documentation fix * Looser bounds on square current magnitude variable * added note to changelog on bfm changes * Tidy Matpower Test Cases (#288) * update case names to be consistent with file names * remove areas block from some test cases * add note to change log * ADD: Warning when fields are missing during PTI parse (#294) Adds a warning enumerating the missing data fields when parsing a PTI file. * Update change log for minor release * update to memento v0.7 (#299) removes depreciation warnings. * prepare change log for v0.7.2 release * Core Multiphase Features (#297) * adding multiphase flag to data parsers * adding ismultiphase test to build_generic_model * making network and phase kwargs in constraint templates * making network and phase kwargs in variable constructors * change usage of pm.ref[:nw] to nws() * exporting multinetwork and multiphase helper functions * minor fix to psse test * multi-phase solution nominally working * adding JSON output for multiphase data * making phases optional to support array-based single phase models * adding isapprox so compare_dict works with multi-phase * adding ref file and making data functions work with multiphase * adding MultiPhaseMatrix to support branch parameters * add support for multiphase duals * minor bugfix to apply_func * adding area, zone, and base_kv to phaseless parameters * adding basic multiphase tests * adding multinetwork multiphase tests * adding run_mn_pf formulation for testing * removed multinetwork models defined in tests * fixing dcline cost function unit conversion * replace getstart with getval, closes #252 * ADD: operators for MultiPhaseValues * REF: multiphasevalues operations * ADD: Unit tests for MultiPhaseValue operations * FIX: DistFlow formulation for multiphase (#289) * Adds more `getmpv` variants * ADD: Unit tests for Multphase and Multinetwork (#300) * ADD: Unit tests for Multphase and Multinetwork * REF: Updated Memento log tests * ADD: Missing unit tests for check_connectivity (#301) * ADD: Missing unit tests for check_connectivity * ADD: Missing ismultiphase test * UPD: updates network checks for multiphase networks (#302) * UPD: updates network checks for multiphase networks * update to changelog * fix spelling of LICENSE * adding basic mathmatical model to docs * minor fix to math-model * making objective functions addative over phases (#308) * Matpower export (#309) * Matpower Export Branch Intermediate backup of this branch * Iterative code backup * intermediate backup * Matpower export Complete * removing .project * add .project to .gitignore * Suggested modifications * updated test due to change to case3.m * add note to changelog [skip ci] * adding Matpower export to acknowledgements [ci skip] * minor fix to acknowledgments [skip ci] * File Parser Enhancements (#311) Closes #310 * move `check_network_data` from `parse_file` into the format-specific parsers: `parse_matpower`, `parse_psse` and `parse_json` ref #310 (comment) 87343 * bugfix * parser support for iostream implemented for `parse_json`, `parse_matpower`, `parse_psse`, and `parse_pti`. ref #310 (comment) 82468 * remove filename kwarg there’s a `.name` attribute in IOStream that I wasn’t previously aware of * add explicit return statements * use in memory buffers instead of creating temp files `::IOStream` -> `::IO` * move matpower_export tests from test/data.jl to test/matpower.jl * adding note to changelog * Remove Series Variables from Branch Flow Formulation (#312) * removing series variables * removing dead code and adding pf hvdc test * rename df.jl to bf.jl, consistency * rename SOCDF to SOCBF, consistency * update AbstractDFForm to AbstractBFForm, consistency * Extended QC Model to Asymmetric Ling Charging (#315) * adding test case for asymmetric line charging * adding opf tests for asymmetric line charging * adding ots tests for asymmetric line charging * extending constraint_power_magnitude_link to asymetric line charge, closes #284 * Fix Parser for HVDC lines with PWL Costs (#317) * do not add HVDC line costs when no HVDC lines exist * fix non-increasing domain on default hvdc pwl costs, and added test case * closes #316 * Update VAD BF Constraint (#318) * remove use of getmpv in constraint_voltage_angle_difference * apply complement to vad constraint * bugfix calc_branch_y TPPM#45 (#319) Uses the pseudo-inverse to avoid issues when certain phases are absent in the impedance matrix. Added corresponding unit test * fix MultiPhaseValue isapprox, closes #320 * FIX: Vector and Matrix Operations on MultiPhaseValues (#321) Fixes problems with MultiPhaseVector and MultiPhaseMatrix operations not being symmetrical, e.g. `Number + MultiPhaseValue` might not work whereas `MultiPhaseValue + Number` might. This has been fixed. Added `inv` function for matrices. Added `real` and `imag` functions for MutliPhaseValues Updated `calc_branch_y`, and one OTS test whose objective value changed due to the difference in rounding errors between doing the calculation in complex vs float types. Closes #313 * fix subscripts in mathmatical model doc * FIX: Line splitting in PTI parser (#323) In String fields, like "name", there can be commas, which was causing special cases (e.g. transformers) to split in the wrong places. Switched all cases to use `get_line_elements` function, which relies on RegEx and handles this case where a comma is in a String field surrounded by single quotes. * add note to changelog * FIX: starbus index (#325) Fixes bug in PSSE parser during the creation of a starbus for 3-winding transformers where the starbus number would keep increasing in magnitude due to `find_max_bus_id` running at every iteration and finding a new, higher max bus id. Fixes this by excluding any busname with `starbus` in it, which is added to the name during the creation of any starbus. * REF: Disables some warnings about missing fields in PTI (#326) Specfically excludes warnings about missing fields in the sections "IMPEDANCE CORRECTION, "MULTI-SECTION LINE", and "SWITCHED SHUNT", which all have optional fields at the end, starting with "T#", "DUM#", and "N#", respectively. * adding video links to readme * FIX: Single-quote in busnames (#329) * FIX: Single-quote in busnames Fixes problem where there could be a quotation mark inside of a bus name by taking advantage of the fact that all busnames in PTI v33.3 must be exactly 12 characters long to be valid. * ADD: Update PTI file to test change Changes one of the busnames to `'1' DROP '` to test change to RegEx * Multi-conductor Renaming (#324) * phase to conductor renaming * update MultiPhase datatypes to MultiConductor * add standard ids names to developer docs * updating file names * rename function args and tmp vars to reflect conductor short names * update for info default logging level, closes #296 (#330) * Some Minor Fixes (#331) * update calc_branch_t to use function dispatch instead of map (close #271 ) * rename mp functions to mc functions * rename mpv to mcv and reduce use of getmcv (close #295) * adding doc string to post_tp_opf in mc tests * adding link to network model video * adding con help to exports * update changelog for v0.8 release * adding implicit single phase to support to buspairs * make add_setpoint more flexible with different types * adding atol to check_tnep_status * update changelog for minor release * fix typo in changelog * bus fix TNEP voltage variable definitions * updating tests for numerical stablity * Tightening QCWRTriModel for opf (#332) * update case5 to test non-contiguous bus ids * tightening QC Tri * update changelog * update MINLP solvers used in testing * OBBT functionality (#335) * obbt initial commit * add docs and stats * add utilities to the docs menu * adding kaarthik sundar to acknowledgments * FIX: import_remaining array eltype check (#336) import_remaining! did not check for eltype of arrays, which broke behavior in ThreePhasePowerModels. Now checks to ensure that arrays have Dict elements. Closes ThreePhasePowerModels#51 * FIX: check_thermal_limits was returning NaN (#337) During check thermal limits, `r` or `x` are zero, `rate_{a,b,c}` would get set to NaN. Using complex formulation and `pinv` to solve this problem. * Adding AbstractBFConicForm (#346) * adding AbstractBFConicForm * adding conic variant of BF model for testing * ADD: Error handling for UnicodeError (#347) Adds Unicode Error message that informs user only UTF-8 and ASCII files are supported, and to re-encode file into a supported format. Adds unit test Closes #328 * Adding #328 note to changelog * update changelog for v0.8.2 * Updated wr.jl Removed a rogue + sign in line 811 * fixing bug in conic objtive (#348) * Add Parallel Time Stat to OBBT (#349) * improve update_data warning message * adding sim_parallel_run_time to the obbt stats * add note to changelog * changlog typo fix * Added Simplification for Piecewise Linear Cost Functions (#350) * simplified multiconductor support in check_cost_functions * adding pwl cost simplification code * adding cost functions checks to matpower exporter * add note to changelog * expanding math model + link to constraint template (#351) * Updated docs (#352) * improving math model docs * Adding references for formulations * References for formulations * Following recommendations in #343 * Updated changelog * Updating docs to address #8 (#356) * improving math model docs * Adding references for formulations * References for formulations * Following recommendations in #343 * Updated changelog * quick fixes per feedback * Addressing #8 + tweaking docs * adding Carpentier reference * Add Support for Current Limits (#354) * add current rating to the branch model * making rates optional * fixing tnep test * add note on optional ratings to docs * adding base current constraint implementation * adding tests for current based opf * add note to changelog * adding test for specifying current limits in matpower data * adding ka_base and rescale_ampere and to unit conversions * Improve OBBT Solver Robustness (#358) * converted error to warnings * cosmetic updated to bibtex entries (#367) * OBBT Change more Errors to Warnings (#370) * Conic form of SOC relaxation (#371) * Add SOC conic form * Tests for SOC conic form * adding SOCWRConicPowerModel to changelog * remove soc conic 6 bus test case due to numerics * use InfrastructureModels.relaxation_complex_product_conic, closes #373 (#374) * Basic Network Flow and Copper Plate Models (#365) * adding network flow approximation formulation * fixing bug in case6 so that there are two components * adding optimal power balance problem * Add version number to Project.TOML * add v0.8.3 version number to change log * Update uuid number according to the registry * Add uuid from Registry Repo * adding julia version upper bound * updating publication reference * Obbt exp (#379) * revised obbt bound update criteria * Message updates * Add note to change log * SDP relaxation with constraint decomposition (#333) * working SDP decomposition * add tests (apply existing SDP tests to SDPDecompForm) * explicit generation of voltage vars and linking constraints * move constraint decomp into struct to keep pm.ext clean * no more infeasible cases! Fixes kersulis#1 * keep only the best decomp implementation, fixes kersulis#2 * bools and ints, not ints and floats * broaden signatures for variable_voltage and constraint_voltage * store graph ordering (suff. to reconstruct minimal chordal ext, cliques) * do not store full adjacency matrix * Minor Tidying of WRM Forms (#380) * rename sdp decomp to sparse * reorg SDP WRM functions * adding sparse sdp to docs * add note to change log * add sdp thanks to readme * adding indentation to ACR doc string * Update Manifest.TOML to newer versions * Citations for sparsity-exploiting SDP OPF (#385) * fix indentation of sparse sdp docstring * update change log for v0.8.4 release * update jump constructor * updating ipopt constructor * update to MOI 0.6 and JuMP master * omit newly broken tests * add link to power flow forms docs to readme * restor power flow tests * adding explicit starting points to variables, restored pwl and qc tri models * Typo fix [ci skip] Fixed a spelling error * WIP, SDP support * minor fix to subscripts in math model docs * update to latest scs version, v0.4.0 * update SCS settings * remove comment * removing extra square from polynomial cost function * update base to use optimization factories * small sdp models working * Update Testing to load default packages * Update testing * update travis.yml * update travis.yml * Fix LinearAlgebra deprecations * fix deprecation of assert to @Assert * Enable testing of Matpower to find deprecations * Update to MOI * Update CI * Update Manifest * Fix typo * add SparseArrays * remove Base.var overloading * Update overloading from Base. to LinearAlgebra. * Remove more deprecated syntax * Remove whitespace deprecations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #316