QC-OTS tests and changelog (#196)

* Bug fix on QC-OTS formulation ``relaxation_product_on_off(pm.model, vm_fr[i], vm_to[j], vv[l], z[l])`` to ``relaxation_product_on_off(pm.model, vm_fr[l], vm_to[l], vv[l], z[l])``
lanl-ansi · Nov 15, 2017 · d3d23bb · d3d23bb
1 parent d5f39ab
commit d3d23bb
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,7 @@ PowerModels.jl Change Log
 =================
 
 ### Staged
+- Fixed bug in QC-OTS formulation
 - Added lambda-based convex hull relaxation scheme for trilinear products
 - Added QCWRTri Power Flow formulation
 

diff --git a/src/form/wr.jl b/src/form/wr.jl
@@ -687,7 +687,7 @@ function constraint_voltage_on_off{T <: QCWRForm}(pm::GenericPowerModel{T}, n::I
 
         relaxation_sin_on_off(pm.model, td[l], si[l], z[l], td_max)
         relaxation_cos_on_off(pm.model, td[l], cs[l], z[l], td_max)
-        relaxation_product_on_off(pm.model, vm_fr[i], vm_to[j], vv[l], z[l])
+        relaxation_product_on_off(pm.model, vm_fr[l], vm_to[l], vv[l], z[l])
         relaxation_product_on_off(pm.model, vv[l], cs[l], wr[l], z[l])
         relaxation_product_on_off(pm.model, vv[l], si[l], wi[l], z[l])
 

diff --git a/test/ots.jl b/test/ots.jl
@@ -139,15 +139,15 @@ end
         check_br_status(result["solution"])
 
         @test result["status"] == :Optimal
-        @test isapprox(result["objective"], 15001.6; atol = 1e0)
+        @test isapprox(result["objective"], 14999.7; atol = 1e0)
     end
     @testset "5-bus asymmetric case" begin
         result = run_ots("../test/data/case5_asym.m", QCWRPowerModel, pajarito_solver)
 
         check_br_status(result["solution"])
 
         @test result["status"] == :Optimal
-        @test isapprox(result["objective"], 15009.4; atol = 1e0)
+        @test isapprox(result["objective"], 14999.7; atol = 1e0)
     end
     @testset "6-bus case" begin
         result = run_ots("../test/data/case6.m", QCWRPowerModel, pajarito_solver)