Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pt] Removed "temp_off" from rules #11244

Merged
merged 2 commits into from
Feb 15, 2025
Merged

Conversation

marcoagpinto
Copy link
Member

@marcoagpinto marcoagpinto commented Feb 15, 2025

Removed "temp_off".

Summary by CodeRabbit

  • New Features

    • Enhanced gerund usage rules for Portuguese, providing broader coverage and improved language processing.
  • Refactor

    • Revised rule configurations to promote a more consistent language processing experience.
    • Updated tone tag formatting for consistency across rules.

Copy link
Contributor

coderabbitai bot commented Feb 15, 2025

Walkthrough

This change updates two language style rules in the Portuguese module by removing the default='temp_off' attribute from both the ATURAR_SUPORTAR_TOLERAR and CHATEAR_INCOMODAR_IMPORTUNAR rules. Additionally, a comment <!-- Used DeepSeek-V3 --> has been added to each rule, indicating the tool or version used during rule processing. Furthermore, modifications were made to the pt-PT/style.xml file, including the removal and addition of entities related to gerund usage, enhancing the rules' coverage.

Changes

File Change Summary
languagetool-language-modules/pt/.../style.xml Removed default='temp_off' attribute from the rules ATURAR_SUPORTAR_TOLERAR and CHATEAR_INCOMODAR_IMPORTUNAR; added comment indicating "Used DeepSeek-V3".
languagetool-language-modules/pt/.../pt-PT/style.xml Removed entities gerundio_excecoes_verbos_auxiliares and gerundio_excecoes_verbos_nao_auxiliares; added new definitions for these entities with broader verb coverage; adjusted tone tags in AVOID_GERUND rule for consistency.

Possibly related PRs

Suggested reviewers

  • jaumeortola

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (6)
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/pt-PT/style.xml (6)

67-68: Improve entity definitions for gerund exceptions

The entities gerundio_excecoes_verbos_auxiliares and gerundio_excecoes_verbos_nao_auxiliares contain very long lists of words. Consider splitting these into multiple smaller, semantically-grouped entities for better maintainability.

For example:

<!ENTITY gerundio_excecoes_movimento "abaixando|andando|correndo|deslizando|entrando|saindo|subindo|voltando">
<!ENTITY gerundio_excecoes_comunicacao "falando|gritando|resmungando|sussurrando">
<!ENTITY gerundio_excecoes_cognicao "aprendendo|entendendo|esquecendo|sabendo">

135-192: Enhance gerund avoidance rule with additional context

The AVOID_GERUND rule is well-structured but could benefit from additional context handling. The current antipatterns may miss some valid cases.

Consider adding antipatterns for:

  1. Fixed expressions where gerund is standard
  2. Temporal clauses with gerund
  3. Adverbial uses of gerund

Example:

<antipattern>
    <!-- Fixed expressions -->
    <token regexp='yes'>água|tempo</token>
    <token>correndo</token>
</antipattern>

2112-2166: Improve handling of verb variations in GASTAR_DESPENDER_DESEMBOLSAR rule

The rule for replacing "gastar" with "despender/desembolsar" is thorough but could be enhanced to handle more verb forms and contexts.

Add support for:

  1. Compound tenses
  2. Passive voice
  3. Reflexive forms

Example:

<antipattern>
    <token inflected='yes'>ter|haver</token>
    <token min='0' max='1'>que</token>
    <token inflected='yes'>gastar</token>
</antipattern>

4401-4418: Enhance simplification rule for passive voice constructions

The rule SIMPLIFICAR_A_SER_PP_A_INF could be improved to handle more complex passive voice constructions.

Add support for:

  1. Negations
  2. Modal verbs
  3. Complex verb chains

Example:

<antipattern>
    <token>não</token>
    <token inflected='yes'>poder|dever</token>
    <token>a</token>
    <token>ser</token>
    <token postag='VMP00S.+' postag_regexp='yes'/>
</antipattern>

4803-4964: Optimize pronoun replacement rules for better coverage

The VERBO_PARA_PRONOME_PESSOAL_V2 rulegroup is comprehensive but could be optimized for better performance and coverage.

  1. Consolidate similar patterns using shared token definitions
  2. Add support for more verb forms
  3. Handle special cases with clitics

Example:

<!ENTITY pronomes_pessoais "mim|ti|si|ele|ela|nós|vós|eles|elas">
<pattern>
    <token postag='V.+' postag_regexp='yes'/>
    <token>para</token>
    <token regexp='yes'>&pronomes_pessoais;</token>
</pattern>

4997-5010: Enhance utility verb replacement rule

The VERBO_SER_ÚTIL_PARA_SERVIR_PARA rule could be expanded to handle more variations of utility expressions.

Add support for:

  1. Synonyms of "útil"
  2. Different verb tenses
  3. Negations

Example:

<pattern>
    <token inflected='yes'>ser</token>
    <token skip='1' regexp='yes'>út(il|eis)|proveitoso|vantajoso</token>
    <token>para</token>
</pattern>
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 60e1ab2 and a106509.

📒 Files selected for processing (1)
  • languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/pt-PT/style.xml (4 hunks)

@marcoagpinto marcoagpinto merged commit 62edaac into master Feb 15, 2025
5 checks passed
@marcoagpinto marcoagpinto deleted the lt_marcoagpinto_20250215_0342 branch February 15, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant