Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[en] Add missing POS and spelling for SI units of measurement [prefix+ electronvolt] #11162

Closed
wants to merge 3 commits into from

Conversation

MikeUnwalla
Copy link
Contributor

@MikeUnwalla MikeUnwalla commented Jan 5, 2025

For the approved prefixes, refer to 'Decimal multiples and sub-multiples of SI units' in The International System of Units (SI) available from https://www.bipm.org/en/publications/si-brochure/

Section 4, 'Non-SI units that are accepted for use with the SI' shows that "The electronvolt is often combined with the SI prefixes."

Summary by CodeRabbit

  • New Features

    • Added comprehensive scientific terminology for electronvolt units, including various metric prefixes from yotta to yocto
    • Expanded spelling dictionary with new scientific and technical terms
  • Documentation

    • Updated language processing resources with precise scientific unit terminology

All verified with https://www.collinsdictionary.com/

@jaumeortola, I added the terms to spelling-eng-GB.txt to prevent confusion (the POS and the spelling agree).
…+ electronvolt]

Refer to 'Decimal multiples and sub-multiples of SI units' in The International System of Units (SI) available from https://www.bipm.org/en/publications/si-brochure/
Copy link
Contributor

coderabbitai bot commented Jan 5, 2025

Walkthrough

This pull request expands the LanguageTool English language modules by adding a comprehensive set of scientific terms related to electronvolts. The changes involve updating two key dictionary files: added.txt and spelling.txt. The additions include singular and plural forms of electronvolt units with various metric prefixes, ranging from yotta to yocto. These entries enhance the language processing capabilities by including precise scientific terminology, specifically covering different orders of magnitude for electronvolts.

Changes

File Change Summary
languagetool-language-modules/en/src/main/resources/org/languagetool/resource/en/added.txt Added 40 new entries for electronvolt terms (singular and plural) with parts of speech (NN/NNS)
languagetool-language-modules/en/src/main/resources/org/languagetool/resource/en/hunspell/spelling.txt Added 41 new entries including electronvolt terms and updated kippot entry

Possibly related PRs

Suggested reviewers

  • jaumeortola

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 58526fe and 6e942c4.

📒 Files selected for processing (2)
  • languagetool-language-modules/en/src/main/resources/org/languagetool/resource/en/added.txt (1 hunks)
  • languagetool-language-modules/en/src/main/resources/org/languagetool/resource/en/hunspell/spelling.txt (1 hunks)
👮 Files not reviewed due to content moderation or server errors (2)
  • languagetool-language-modules/en/src/main/resources/org/languagetool/resource/en/hunspell/spelling.txt
  • languagetool-language-modules/en/src/main/resources/org/languagetool/resource/en/added.txt
🧰 Additional context used
🪛 LanguageTool
languagetool-language-modules/en/src/main/resources/org/languagetool/resource/en/added.txt

[duplication] ~1081-~1081: Possible typo: you repeated a word
Context: ...ottaelectronvolts yottaelectronvolt NNS zettaelectronvolt zettaelectronvolt NN zettaelectronvolts zettaelectronvolt...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~1083-~1083: Possible typo: you repeated a word
Context: ...ettaelectronvolts zettaelectronvolt NNS exaelectronvolt exaelectronvolt NN exaelectronvolts exaelectronvolt NNS...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~1085-~1085: Possible typo: you repeated a word
Context: ...NN exaelectronvolts exaelectronvolt NNS petaelectronvolt petaelectronvolt NN petaelectronvolts petaelectronvolt N...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~1087-~1087: Possible typo: you repeated a word
Context: ... petaelectronvolts petaelectronvolt NNS teraelectronvolt teraelectronvolt NN teraelectronvolts teraelectronvolt N...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~1089-~1089: Possible typo: you repeated a word
Context: ... teraelectronvolts teraelectronvolt NNS gigaelectronvolt gigaelectronvolt NN gigaelectronvolts gigaelectronvolt N...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~1091-~1091: Possible typo: you repeated a word
Context: ... gigaelectronvolts gigaelectronvolt NNS megaelectronvolt megaelectronvolt NN megaelectronvolts megaelectronvolt N...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~1093-~1093: Possible typo: you repeated a word
Context: ... megaelectronvolts megaelectronvolt NNS kiloelectronvolt kiloelectronvolt NN kiloelectronvolts kiloelectronvolt N...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~1095-~1095: Possible typo: you repeated a word
Context: ... kiloelectronvolts kiloelectronvolt NNS hectoelectronvolt hectoelectronvolt NN hectoelectronvolts hectoelectronvolt...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~1097-~1097: Possible typo: you repeated a word
Context: ...ectoelectronvolts hectoelectronvolt NNS decaelectronvolt decaelectronvolt NN decaelectronvolts decaelectronvolt N...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~1099-~1099: Possible typo: you repeated a word
Context: ... decaelectronvolts decaelectronvolt NNS decielectronvolt decielectronvolt NN decielectronvolts decielectronvolt N...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~1101-~1101: Possible typo: you repeated a word
Context: ... decielectronvolts decielectronvolt NNS centielectronvolt centielectronvolt NN centielectronvolts centielectronvolt...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~1103-~1103: Possible typo: you repeated a word
Context: ...entielectronvolts centielectronvolt NNS millielectronvolt millielectronvolt NN millielectronvolts millielectronvolt...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~1105-~1105: Possible typo: you repeated a word
Context: ...illielectronvolts millielectronvolt NNS microelectronvolt microelectronvolt NN microelectronvolts microelectronvolt...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~1107-~1107: Possible typo: you repeated a word
Context: ...icroelectronvolts microelectronvolt NNS nanoelectronvolt nanoelectronvolt NN nanoelectronvolts nanoelectronvolt N...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~1109-~1109: Possible typo: you repeated a word
Context: ... nanoelectronvolts nanoelectronvolt NNS picoelectronvolt picoelectronvolt NN picoelectronvolts picoelectronvolt N...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~1111-~1111: Possible typo: you repeated a word
Context: ... picoelectronvolts picoelectronvolt NNS femtoelectronvolt femtoelectronvolt NN femtoelectronvolts femtoelectronvolt...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~1113-~1113: Possible typo: you repeated a word
Context: ...emtoelectronvolts femtoelectronvolt NNS attoelectronvolt attoelectronvolt NN attoelectronvolts attoelectronvolt N...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~1115-~1115: Possible typo: you repeated a word
Context: ... attoelectronvolts attoelectronvolt NNS zeptoelectronvolt zeptoelectronvolt NN zeptoelectronvolts zeptoelectronvolt...

(ENGLISH_WORD_REPEAT_RULE)


[duplication] ~1117-~1117: Possible typo: you repeated a word
Context: ...eptoelectronvolts zeptoelectronvolt NNS yoctoelectronvolt yoctoelectronvolt NN yoctoelectronvolts yoctoelectronvolt...

(ENGLISH_WORD_REPEAT_RULE)


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

danielnaber added a commit that referenced this pull request Jan 7, 2025
@danielnaber
Copy link
Member

Added here

@danielnaber danielnaber closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants