-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pt] More verbs/nouns fixes in disambiguation.xml V2 #11158
Conversation
WalkthroughThe pull request modifies the Portuguese language disambiguation rules in the Changes
Possibly related issues
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml (1)
4151-4160
: LGTM! Consider adding examples in comments.The rule logic for disambiguating verbs vs nouns is sound. The pattern matching and exceptions are well structured.
Consider adding more examples in comments to illustrate the cases this rule handles, similar to the examples provided in other rules. This would help future maintainers understand the rule's purpose.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml
(2 hunks)
🔇 Additional comments (1)
languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml (1)
4176-4179
: LGTM! Good documentation with examples.The added examples effectively illustrate the rule's application in different contexts.
It didn't break Premium! Another milestone, fixing the verbs/nouns! |
Ahhhh... I decided to start from "fresh" (V2) the last commits.
Summary by CodeRabbit