[pt] Removed "temp_off" from rule ID:TER_PARTICIPIO-PASSADO_V2

[marcoagpinto]

Just removed "temp_off" and made the suggestion shorter.

Summary by CodeRabbit

• New Features
  • Updated Portuguese language rule for improved clarity in examples.
  • Removed the default setting for the rule related to "Ter + Particípio passado."
  • Enhanced guidance for using present perfect and indicative tenses in examples.

[coderabbitai]

Walkthrough

The pull request modifies the style.xml file for Portuguese language rules in LanguageTool by updating the rule TER_PARTICIPIO-PASSADO_V2. The default attribute has been removed, and the associated message examples have been changed to improve clarity. This reflects an effort to refine the guidance provided by this specific rule.

Changes

File Path	Change Summary
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/style.xml	- Removed default='temp_off' from rule TER_PARTICIPIO-PASSADO_V2. - Updated message examples.

Possibly related PRs

• [pt] Removed "temp_off" from rule ID:OS_DOIS_AS_DUAS_AMBOS_AMBAS #10870: Removal of the default='temp_off' attribute from a rule in the same style.xml file.
• [pt] Removed "temp_off" from rule ID:OS_DOIS_AS_DUAS_AMBOS_AMBAS #10887: Modification of the same rule group, specifically removing the default='temp_off' attribute from the OS_DOIS_AS_DUAS_AMBOS_AMBAS rule.
• [pt] Fixed and removed "temp_off" from rule ID:PARA_NADA_DESNECESSARIAMENTE #10908: Removal of the temp_off attribute from another rule in the same style.xml file.
• [pt-PT] Removed "temp_off" from rule ID:VERBO_PRONOMINAL_DE_V3 #10912: Removal of the temp_off designation from a rule in the style.xml file.
• [pt-PT] Removed temp_off from subrule in rule ID:INFORMALITIES #10914: Removal of the temp_off designation from a subrule in the same style.xml file.
• [pt-PT] Removed "temp_off" from rules #10935: Discussion on the removal of temp_off from multiple rules, aligning with the main PR's changes.
• [pt] Rewrote rule ID:TER_PARTICIPIO-PASSADO #11085: Rewrite of the rule related to TER_PARTICIPIO-PASSADO, directly connected to the main PR's modifications.

Suggested reviewers

• jaumeortola

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 73f2cea and fbd3866.

📒 Files selected for processing (1)

• languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/style.xml (2 hunks)

🔇 Additional comments (2)

languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/style.xml (2)

11585-11585: LGTM! The updated examples are clear and relatable

The change from "estudar" to "ler" in the examples provides a more universally applicable context while maintaining the same grammatical principle. The message effectively explains the distinction between continuous actions (presente perfeito) and habitual actions (indicativo).

---

11561-11561: Verify implications of enabling this rule by default

Removing default='temp_off' will make this rule active by default. Please confirm:

1. Was this intentional?
2. Has this rule been sufficiently tested with a variety of Portuguese texts?
3. Are there any known false positives that were previously avoided by having this rule disabled by default?

✅ Verification successful

Enabling this rule appears to be safe and intentional

The rule is well-defined with:

• Clear antipatterns to prevent false positives in interrogative sentences
• Multiple example cases showing correct usage
• Proper tags indicating it's a 'picky' style rule for 'objective' tone
• Documentation noting it was enhanced with AI assistance for accuracy

The removal of default="temp_off" aligns with the rule's maturity and implementation quality. The 'picky' tag also ensures users understand this is a style suggestion rather than a critical grammar rule.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for any related test cases or documentation
rg -l "TER_PARTICIPIO-PASSADO_V2" --type xml --type java

# Look for any discussions or issues related to this rule
gh issue list --search "TER_PARTICIPIO-PASSADO_V2"

Length of output: 195

---

Script:

#!/bin/bash
# Let's examine the rule definition and its test cases more closely
rg -A 10 -B 10 "TER_PARTICIPIO-PASSADO_V2" --type xml

# Check if there are any test files for Portuguese rules
fd ".*test.*\.xml" languagetool-language-modules/pt/

# Look for any commit history related to this rule
git log --oneline -S "TER_PARTICIPIO-PASSADO_V2"

Length of output: 3161

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.