Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pt] Revert English corrections #10653

Merged
merged 7 commits into from
Jun 13, 2024

Conversation

p-goulart
Copy link
Collaborator

This PR restores most of the reverted changes from #10652, but, crucially, not the English speller calls from the PT Morfologik class. For now, I am backlogging that.

  • the tests I ran locally failed to account for some things, mostly proper nouns;

  • we ended up with a lot of semi-valid corrections on proper nouns, which... although technically correct, since those words aren't recognised by the English speller, we shouldn't be introducing;

  • I could limit it to words starting with an uppercase letter, but that would need some further testing.


This means we keep v1.1.0 of the dictionary and the new simple replace orthography rule, as well as the ok/OK grammar rule, but we lose the English corrections.

@p-goulart
Copy link
Collaborator Author

(I'm fixing tests locally and pushing in parallel to save time, so some CircleCI tests needed to be cancelled.)

@p-goulart p-goulart merged commit 54fa9f6 into master Jun 13, 2024
3 checks passed
@p-goulart p-goulart deleted the pt/dict/revert_only_english_corrections branch June 13, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants