Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct fetch_from for customizable models #12400

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

kurokobo
Copy link
Contributor

@kurokobo kurokobo commented Jan 6, 2025

Summary

This PR is for fix/chore-fix branch, as a follow-up for #12372.

This PR fixes the issue that customizable models are treated as predefined models by API which causes the missing Config button for customizable models on Web UI.

Additional context: https://discord.com/channels/1082486657678311454/1324964911356317736, #12372 (comment)

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Jan 6, 2025
Copy link
Collaborator

@Yeuoly Yeuoly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 6, 2025
@Yeuoly Yeuoly merged commit 8d75abc into langgenius:fix/chore-fix Jan 6, 2025
@kurokobo kurokobo deleted the fix-fetch_from branch January 6, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants