-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vdb): add HNSW vector index for TiDB vector store with TiFlash #12043
Conversation
08cc63b
to
1ca40ee
Compare
8214c02
to
61d846f
Compare
1ce4b1e
to
843a0ac
Compare
04cd8c8
to
d5e8d2a
Compare
Hi, is there any blocking issue or advice for this PR? Feel free to ask me to follow. cc @JohnJyong @laipz8200 |
d5e8d2a
to
9311dbd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Some comments about the most recent Vector Index syntax.
Thanks for the detailed reviews from TiDB Team! Will have feedback code changes soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved all the comments.
Summary
Screenshots
Checklist
Important
Please review the checklist below before submitting your pull request.
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint gods