-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(models): update fern api #1071
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disclaimer: Experimental PR review
PR Summary
This PR updates the Fern API integration across the Langfuse Python SDK, making several key changes:
- Simplified import paths by removing the 'api' namespace, changing from
langfuse.api
tolangfuse
andlangfuse.api.client
tolangfuse.client
throughout documentation and examples - Made the
unit
field optional inCreateModelRequest
by adding a default value ofNone
- Added content_type parameter to media upload requests
- Added data model documentation links to improve API reference clarity
- Updated core module paths from
langfuse.api.core
tolangfuse.core
in test files
The changes primarily focus on import path restructuring and documentation improvements while maintaining backward compatibility.
25 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disclaimer: Experimental PR review
PR Summary
(updates since last review)
This PR updates the start_date
field type in the Model class from dt.date
to dt.datetime
, enabling more granular time-based filtering of model definitions.
- Changed
start_date
type in/langfuse/api/resources/commons/types/model.py
fromdt.date
todt.datetime
for finer temporal control - Updated corresponding field in
/langfuse/api/resources/models/types/create_model_request.py
to maintain type consistency
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disclaimer: Experimental PR review
PR Summary
(updates since last review)
Based on the provided information, I'll summarize the key changes in this PR that haven't been mentioned in previous reviews:
The PR makes several significant changes to the Langfuse Python SDK:
- Changed
unit
field inCreateModelRequest
to be optional without validation logic, which could potentially impact model pricing calculations - Updated all import paths in example code blocks across multiple client files to maintain consistency with the package rename
- Added proper datetime serialization configuration in the Model class to handle the new
start_date
field type - Maintained error handling and core functionality across all client implementations while updating package structure
Key points to consider:
- Making the
unit
field optional without validation logic could lead to issues if the unit is required for certain model types - The datetime change for
start_date
appears to be properly implemented with correct serialization handling - The package rename changes are consistently applied across all documentation and example code
These changes complement the previous reviews while highlighting new aspects of the implementation that warrant attention.
24 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Important
Renamed package from
langfuse.api
tolangfuse
, updated imports across multiple files, changedstart_date
field todatetime
, and updated documentation.langfuse.api
tolangfuse
across multiple files, includingclient.py
incomments
,dataset_items
,datasets
,health
,ingestion
,media
,metrics
,models
,observations
,projects
,prompts
,score
,score_configs
,sessions
, andtrace
.start_date
field fromdate
todatetime
inCreateModelRequest
andModel
.README.md
andreference.md
to reflect package rename and usage changes.This description was created by for 62e41ac. It will automatically update as commits are pushed.