Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(serializer): remove unnecessary log statement #1061

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

hassiebp
Copy link
Contributor

@hassiebp hassiebp commented Jan 6, 2025

Important

Remove unnecessary print statement from default() method in EventSerializer class in serializer.py.

  • Code Cleanup:
    • Removed unnecessary print(obj.__dict__) statement from default() method in EventSerializer class in serializer.py.

This description was created by Ellipsis for 81a857d. It will automatically update as commits are pushed.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disclaimer: Experimental PR review

PR Summary

Removed unnecessary print statement in serializer to prevent potential exposure of sensitive information during serialization failures.

  • Removed debug print of object's __dict__ in langfuse/serializer.py while keeping controlled logger.debug statement
  • Maintains existing serialization error handling while improving security and logging control

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@hassiebp hassiebp merged commit e54ab93 into main Jan 6, 2025
7 of 8 checks passed
@hassiebp hassiebp deleted the fix-serializer-unnecessary-log branch January 6, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Functions dramatically slower when using langfuse, lots of logs being dumped.
1 participant