fix: add default value in deprecated argument

[Swalloow]

Added a default value of None to the trace_or_observation for optional usage.
It prevents potential confusion for users by clearly indicating the optional and deprecated parameter.

---

Important

Added default value None to trace_or_observation parameter in link() function in client.py to indicate it is optional and deprecated.

• Function Signature:
  • In link() function in client.py, added default value None to trace_or_observation parameter.
  • This change clarifies that trace_or_observation is optional and deprecated.

^{This description was created by for 391d284. It will automatically update as commits are pushed.}

[CLAassistant]

All committers have signed the CLA.

[greptile-apps]

Disclaimer: Experimental PR review

PR Summary

Improved parameter handling in the DatasetItemClient's link method by adding default value for deprecated parameter.

• Modified langfuse/client.py to set default value of None for deprecated trace_or_observation parameter
• Reordered parameter position in link method signature to place deprecated parameter last
• Updated docstring to reflect parameter changes and deprecation status

_{💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!}

_{1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile}

[marcklingen]

Unfortunately, this was a positional argument in the original api here and later on the keyword arguments were added. @hassiebp can you review?

To me it seems like this requires a major bump as it is a breaking change. If yes, I’d suggest to add this in the next major version as this is clearly tech debt in this interface.

[hassiebp]

Thanks for your contribution!

[hassiebp]

Apologies, had to revert this PR here. As Marc has mentioned, the current interface expects positional arguments, such that moving the position of that argument would not be backwards compatible.

[Swalloow]

How should I fix this to include it in the next major version?

[hassiebp]

@Swalloow - we have not yet created a v3 branch for which a PR such as this one could be merged into. We have created an internal task though with this PR linked in order to make sure this will be part of our next major release. Thanks again for your contribution!