Fix RegexParser including double slashes in prompt #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RegexParser was including the /regex/ slashes in its output, but those are already included when converting a RegExp to string. Therefore prompts looked like //0-9//, which is not a common regex notation. Models get confused and include literal // in their responses, which can be seen in the examples. Fix: remove slashes from RegexParser output, and rely on those from converting RegExp to string. Also included an example of how to use RegexParser. Also re-ran examples and pasted output in comments.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@jameshfisher Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RegexParser was including the /regex/ slashes in its output, but those are already included when converting a RegExp to string. Therefore prompts looked like //0-9//, which is not a common regex notation. Models get confused and include literal // in their responses, which can be seen in the examples.
Fix: remove slashes from RegexParser output, and rely on those from converting RegExp to string.
Also included an example of how to use RegexParser.
Also re-ran examples and pasted output in comments.