Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing function execution in streaming example in getting started guide #805

Merged
merged 4 commits into from
Apr 17, 2023

Conversation

choonkeat
Copy link
Contributor

followup for #691

  1. import statement has warning
  2. example exits immediately with no output

@vercel
Copy link

vercel bot commented Apr 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Apr 17, 2023 2:11pm

Copy link
Collaborator

@nfcampos nfcampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, one comment

examples/src/models/chat/chat_streaming_stdout.ts Outdated Show resolved Hide resolved
@nfcampos nfcampos added the lgtm PRs that are ready to be merged as-is label Apr 17, 2023
@nfcampos nfcampos merged commit b298d83 into langchain-ai:main Apr 17, 2023
RohitMidha23 pushed a commit to RohitMidha23/langchainjs that referenced this pull request Apr 18, 2023
…d guide (langchain-ai#805)

* Add missing function execution

and fix import

* Fix this example too

* use execution framework setup by langchain-ai#841

* fix format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm PRs that are ready to be merged as-is
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants