Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(openai): Properly pass through max_completion_tokens #7683

Merged
merged 3 commits into from
Feb 11, 2025

Conversation

jacoblee93
Copy link
Collaborator

@jacoblee93 jacoblee93 commented Feb 11, 2025

Fixes #7648

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Feb 11, 2025
Copy link

vercel bot commented Feb 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 10:11pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Feb 11, 2025 10:11pm

@dosubot dosubot bot added the auto:improvement Medium size change to existing code to handle new use-cases label Feb 11, 2025
@jacoblee93 jacoblee93 merged commit 92edca1 into main Feb 11, 2025
32 checks passed
@jacoblee93 jacoblee93 deleted the jacob/reasoning branch February 11, 2025 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:improvement Medium size change to existing code to handle new use-cases size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ChatOpenAI with o3-mini fails when pulling a prompt with model from Langsmith using pull
1 participant