Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat (google-*): Support Google Cloud Express Mode #7676

Merged
merged 5 commits into from
Feb 21, 2025
Merged

feat (google-*): Support Google Cloud Express Mode #7676

merged 5 commits into from
Feb 21, 2025

Conversation

afirstenberg
Copy link
Contributor

@afirstenberg afirstenberg commented Feb 9, 2025 •
edited
Loading

Supports Google Cloud Express Mode by

  • Changing how we handle API Keys
  • Changing the URL used on GCP when an API Key Client is used

Fixes #7674

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Feb 9, 2025
@vercel Vercel
Copy link

vercel bot commented Feb 9, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2025 0:18am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Feb 21, 2025 0:18am

@afirstenberg afirstenberg marked this pull request as draft February 9, 2025 03:26
@dosubot dosubot bot added the auto:improvement Medium size change to existing code to handle new use-cases label Feb 9, 2025
@afirstenberg afirstenberg changed the title Support Google Cloud Express Mode feat (google-*): Support Google Cloud Express Mode Feb 9, 2025
@afirstenberg afirstenberg mentioned this pull request Feb 11, 2025
Closed
1 task
@afirstenberg afirstenberg marked this pull request as ready for review February 15, 2025 16:41
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Feb 15, 2025
@afirstenberg
Copy link
Contributor Author

@jacoblee93 - Ready for review (and hopeful merge)

@jacoblee93
Copy link
Collaborator

Will look today or tomorrow! Thank you!

jacoblee93
jacoblee93 reviewed Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@jacoblee93 jacoblee93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really, really sorry about the delay!

@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label Feb 21, 2025
@jacoblee93 jacoblee93 merged commit 27e6538 into langchain-ai:main Feb 21, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacoblee93 jacoblee93 jacoblee93 approved these changes

Assignees
No one assigned
Labels
auto:improvement Medium size change to existing code to handle new use-cases lgtm PRs that are ready to be merged as-is size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat (google-vertex): Support Vertex Express Mode
2 participants
@afirstenberg @jacoblee93