Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serpapi results coming back in another region/languge #766

Merged
merged 4 commits into from
Apr 13, 2023

Conversation

jacobrosenthal
Copy link
Contributor

@jacobrosenthal jacobrosenthal commented Apr 12, 2023

closes #765

Screenshot from 2023-04-12 11-13-26

I contacted support because just going back to a search from last weeks It was all in english (Im in Phoenix USA)
So I dont think we changed anything in the api.
TLDR is unless you set location (and possibly hl and gl) they dont seem to guarantee anything

Just setting location fixed it for me for now.. It seems like alot to add the hg and gl as well, maybe we can get away without it

Updated all examples with a default location. their docs mention Austin so I just used that

The first thing I notice is that you have not used any location parameters. For consistent language/location results, you need to specify the location, hl and gl parameters. Without these, your search can take the proxy's location, which may deliver unexpected results. We recommend always using the most specific location parameters possible in order to simulate a real user's search.
I understand that you have not experienced this before, and your parameters may not have changed. However, by not using these parameters you are not exercising control over the location for which the results are delivered.
Let me know if you continue to experience this after including location parameters.

For best results I would still recommend using the hl and gl as well, however you may not notice the difference, I can't say for sure.

@vercel
Copy link

vercel bot commented Apr 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Apr 13, 2023 5:10am

@jacobrosenthal
Copy link
Contributor Author

Nope still happening. Let me try to set those other 2

langchain-examples:start: Перевод "emolument" на русский. Сущ. вознаграждение n.
langchain-examples:start: "observation": "«Новый агент Макгайвер» — американский приключенческий телесериал, ремейк «Секретного агента Макгайвера», транслировавшегося на ABC с 1985 по 1992 год. Премьера сериала состоялась 23 сентября 2016 года на телеканале CBS."

@nfcampos nfcampos added the lgtm PRs that are ready to be merged as-is label Apr 13, 2023
@nfcampos
Copy link
Collaborator

Thanks!

@nfcampos nfcampos merged commit 4f67ed3 into langchain-ai:main Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm PRs that are ready to be merged as-is
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add some note in SerpApi Tool docs about needing to set location
2 participants