Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(community): Make postgresConnectionOptions optional in PostgresRecordManager #7580

Merged
merged 2 commits into from
Jan 25, 2025
Merged

fix(community): Make postgresConnectionOptions optional in PostgresRecordManager #7580

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
265f4a9
Make postgresConnectionOptions optional in PostgresRecordManager
JonathanVelkeneers Jan 24, 2025
c8ba544
Format
jacoblee93 Jan 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions libs/langchain-community/src/indexes/postgres.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {
} from "./base.js";

export type PostgresRecordManagerOptions = {
postgresConnectionOptions: PoolConfig;
postgresConnectionOptions?: PoolConfig;
pool?: Pool;
tableName?: string;
schema?: string;
Expand All @@ -26,7 +26,10 @@ export class PostgresRecordManager implements RecordManagerInterface {
constructor(namespace: string, config: PostgresRecordManagerOptions) {
const { postgresConnectionOptions, tableName, pool } = config;
this.namespace = namespace;
this.pool = pool || new pg.Pool(postgresConnectionOptions);
if (!postgresConnectionOptions && !pool) {
throw new Error("You must provide either a `postgresConnectionOptions` object or a `pool` instance.");
}
this.pool = pool ?? new pg.Pool(postgresConnectionOptions);
this.tableName = tableName || "upsertion_records";
this.finalTableName = config.schema
? `"${config.schema}"."${this.tableName}"`
Expand Down
Loading