Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(openai): update azure user agent #7543

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

chore(openai): update azure user agent #7543

wants to merge 6 commits into from

Conversation

sinedied
Copy link
Contributor

Changes

Fix library name and versioning, and add details about the Node.js version and platform in the user agent

@vercel Vercel
Copy link

vercel bot commented Jan 17, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Feb 10, 2025 10:07am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Feb 10, 2025 10:07am

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 17, 2025
@dosubot dosubot bot added the auto:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs label Jan 17, 2025
jacoblee93
jacoblee93 approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@jacoblee93 jacoblee93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

libs/langchain-openai/src/azure/chat_models.ts Outdated Show resolved Hide resolved
@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label Jan 22, 2025
jacoblee93
jacoblee93 previously requested changes Jan 22, 2025
View reviewed changes
libs/langchain-openai/src/azure/chat_models.ts Outdated Show resolved Hide resolved
@dosubot dosubot bot removed the lgtm PRs that are ready to be merged as-is label Jan 22, 2025
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Feb 5, 2025
jacoblee93
jacoblee93 approved these changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@jacoblee93 jacoblee93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label Feb 5, 2025
@jacoblee93
Copy link
Collaborator

Also looks like lint is failing:

Error:   6:24  error  '@langchain/core/utils/env' imported multiple times  import/no-duplicates
Error:   7:40  error  '@langchain/core/utils/env' imported multiple times  import/no-duplicates

@jacoblee93
Copy link
Collaborator

@sinedied happy to merge as is, but LMK if you want to do this: #7543 (comment)

@sinedied
Copy link
Contributor Author

sinedied commented Feb 6, 2025

I've fixed the extra space, should be good now!

@sinedied
Copy link
Contributor Author

@jacoblee93 I think all issues are now resolved, could you have a look? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnpapa johnpapa johnpapa left review comments

@jacoblee93 jacoblee93 jacoblee93 approved these changes

Assignees
No one assigned
Labels
auto:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs lgtm PRs that are ready to be merged as-is size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sinedied @jacoblee93 @johnpapa