Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(community): remove docs for Watsonx IBM deprecated implementation #7306

Merged
merged 7 commits into from
Jan 9, 2025

Conversation

FilipZmijewski
Copy link
Contributor

Removing docs for the depricated implementation since this is confusing for users

* Fixed missing tool_choice in call options of chat (#30)

* Add rerank implementation to existing IBM community implementation (#25)

Extend existing implementation

- rename variables to camelCase
- remove default values for model
- Update and remove some tests
- update urls in documentation, shrink outputs

* Add fixes according to review (#32)

* Add fixes according to review
* Upload config info

* Fix notebooks

* Fix notebook

* Add to sidebar

* Show in docs

* Fix doc

---------

Co-authored-by: jacoblee93 <jacoblee93@gmail.com>
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 3, 2024
Copy link

vercel bot commented Dec 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Jan 8, 2025 2:56pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Jan 8, 2025 2:56pm

@FilipZmijewski FilipZmijewski marked this pull request as draft December 3, 2024 08:31
@dosubot dosubot bot added auto:documentation Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder auto:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs labels Dec 3, 2024
@FilipZmijewski FilipZmijewski marked this pull request as ready for review December 3, 2024 08:32
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Dec 3, 2024
@jacoblee93
Copy link
Collaborator

Can you add a redirect in vercel.json to the new page?

@FilipZmijewski
Copy link
Contributor Author

Done, also fixed one url in rerank

@FilipZmijewski
Copy link
Contributor Author

FilipZmijewski commented Jan 8, 2025

@jacoblee93 I removed branch on my repo before we managed to merge that. Could you have a look at it one more time, please?

Copy link
Collaborator

@jacoblee93 jacoblee93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label Jan 9, 2025
@jacoblee93 jacoblee93 changed the title docs[community]: remove docs for Watsonx IBM deprecated implementation docs(community): remove docs for Watsonx IBM deprecated implementation Jan 9, 2025
@jacoblee93 jacoblee93 merged commit bd89717 into langchain-ai:main Jan 9, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:documentation Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder auto:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs lgtm PRs that are ready to be merged as-is size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants