-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update queue type to avoid build error #673
Conversation
Existing code gives this error node_modules/langchain/dist/util/async_caller.d.ts:30:22 - error TS2702: 'PQueueMod' only refers to a type, but is being used as a namespace here. 30 protected queue: PQueueMod.default; This PR fixes it..
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
@ashburnham see the "Build and check types" CI job result, this appears to make the build fail on CI (and in my laptop). Can you share more about what's different about your environment |
I'm using it in a
It took me a while to get it does so that this is the only error left, and it seems it was as my PR suggests only 3 days ago... so I was hoping it could be changed back. Alternatively, any other workaround to make it work in a commonjs project would be very helpful! 🙏🙏🙏🙏 p.s. I've been followinf this issue, which is related, but none of it works for me. |
p.s. I'm going |
I've committed an alternative here which I think fixes it, but in testing your tsconfig it seems to be invalid, eg. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a good solution! Thanks!
This was released on 0.0.51, please try again |
Existing code gives this error
node_modules/langchain/dist/util/async_caller.d.ts:30:22 - error TS2702: 'PQueueMod' only refers to a type, but is being used as a namespace here.
30 protected queue: PQueueMod.default;
This PR fixes it..