-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
langchain[minor]: Support storing and retrieving Document id field in MemoryVectorStore #6572
Merged
bracesproul
merged 2 commits into
langchain-ai:main
from
dschenkelman:memoryVectorWithId
Aug 22, 2024
Merged
langchain[minor]: Support storing and retrieving Document id field in MemoryVectorStore #6572
bracesproul
merged 2 commits into
langchain-ai:main
from
dschenkelman:memoryVectorWithId
Aug 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
c5f3974
to
9f3bac6
Compare
fb9f9cb
to
2c74f3f
Compare
Hey team, what's the best way to get feedback on this one? |
bracesproul
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. If CI passes I can get it merged in. Thank you
happy to help 😄 |
This was referenced Sep 13, 2024
CarterMorris
pushed a commit
to CarterMorris/langchainjs
that referenced
this pull request
Nov 10, 2024
… MemoryVectorStore (langchain-ai#6572) Co-authored-by: dschenkelman <dmaian.schenkelman@gmail.com> Co-authored-by: Brace Sproul <braceasproul@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto:improvement
Medium size change to existing code to handle new use-cases
lgtm
PRs that are ready to be merged as-is
size:M
This PR changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #6577