Add implementation of Prisma vectorstore #440
Conversation
43cd9ed to
b5306ad
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
| const pageContent = typeof metadata[this.contentColumn]; | ||
| if (pageContent !== "string") | ||
| throw new Error("Content column must be a string"); | ||
| return new Document({ pageContent, metadata }); |
There was a problem hiding this comment.
I think we'd want to remove the pageContent from metadata?
There was a problem hiding this comment.
At the moment, it returns the subset a Prisma model (TModel and TSelectModel), which do include the this.contentColumn).
We could remove the content column from the metadata, but I would argue that the metadata should contain the same columns, as user specifies in the dbConfig.
|
hello @dqbd, I was wondering if we could use typeorm to avoid adding another orm in the dependencies? |
|
Hi @MaximeThoonsen!
Both Regardless, I think a TypeORM vectorstore implementation is certainly doable. Will look into it and possibly create a separate PR. |
Add an implementation of Prisma vectorstore, with type safety in mind.
1. Prisma vectorstore implements a mock interface, as it depends on the types generated via
prisma generateThis does mean that the code might be unnecessary brittle compared to hardcoding
@prisma/clientdirectly in user codebases.2. Added optional generic type argument for Document metadata
Developers can now specify a concrete type for
metadataprop inDocument. AFAIK this does not propagate in chains etc, but I believe this to be an useful starting block.3.
fromDocumentsandfromTextsis currently unsupportedAs there is a significant difficulty upserting entire documents, I've marked these methods as
@deprecatedfor now.