Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

community: fix some features on Naver ChatModel & embedding model 2 #29243

Merged
merged 7 commits into from
Jan 20, 2025
Merged

community: fix some features on Naver ChatModel & embedding model 2 #29243

merged 7 commits into from
Jan 20, 2025
+240 −97

Conversation

hyper-clova
Copy link
Contributor

@hyper-clova hyper-clova commented Jan 16, 2025 •
edited
Loading

Description

  • Responding to NCP API Key changes.
  • To fix ChatClovaX astream function to raise SSEError when an error event occurs.
  • To add token length and ai_filter to ChatClovaX's response_metadata.
  • To update document for apply NCP API Key changes.

cc. @efriis @vbarda

@vercel Vercel
Copy link

vercel bot commented Jan 16, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 9:57am

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. community Related to langchain-community Ɑ: embeddings Related to text embedding models module 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels Jan 16, 2025
@joonha-jeon
Copy link

Hi, Joonha from Naver here.

Just wanted to share our thoughts following @efriis 's feedback on our previous PR (#28228)

We understand the direction towards moving integrations out of langchain-community to partner-managed packages.

For our integration, we'd like to propose the following timeline:
We'll maintain our current integration in langchain-community through Q1 2025, as we've recently integrated and have active users relying on it.
Starting Q2 2025, we plan a transition to our own partner package, which will align with some significant product updates we have in the pipeline.

Really appreciate in advance for the review, and the amazing work you all do maintaining LangChain :)
Looking forward to your thoughts on this approach.

Best regards!

ccurme
ccurme approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@ccurme ccurme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @joonha-jeon, that timeline will work fine. Please let us know if you have questions when publishing the dedicated package.

@ccurme ccurme merged commit 7a95ffc into langchain-ai:master Jan 20, 2025
21 checks passed
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccurme ccurme ccurme approved these changes

Assignees
No one assigned
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature community Related to langchain-community 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder Ɑ: embeddings Related to text embedding models module lgtm PR looks good. Use to confirm that a PR is ready for merging. size:L This PR changes 100-499 lines, ignoring generated files.
Projects
PR Reviews
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hyper-clova @joonha-jeon @ccurme