tests[patch]: update API ref for chat models #28594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
efriis
approved these changes
Dec 6, 2024
| @@ -145,6 +145,14 @@ def chat_model_params(self) -> dict: | |||
| By default, this is determined by whether the chat model's `bind_tools` method | |||
| is overridden. It typically does not need to be overridden on the test class. | |||
|
|
|||
| Example override: | |||
| @@ -1323,8 +1331,8 @@ def has_tool_calling(self) -> bool: | |||
| .. code-block:: python | |||
|
|
|||
| @pytest.mark.xfail(reason=("Not implemented.")) | |||
| def test_tool_message_histories_string_content(self, model: BaseChatModel) -> None: | |||
| super().test_tool_message_histories_string_content(model) | |||
| def test_tool_message_histories_string_content(self, *args: Any) -> None: | |||
There was a problem hiding this comment.
smart - should we pass **kwargs too? Just in case we add kwargs for some reason in future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.