partners: update pinecone client #28320
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| numpy = [ | ||
| { version = "^1", python = "<3.12" }, | ||
| { version = "^1.26.0", python = ">=3.12" } |
There was a problem hiding this comment.
Just a structural change to make things cleaner
| @@ -74,6 +74,7 @@ class PineconeVectorStore(VectorStore): | |||
| dimension=1536, | |||
| metric="cosine", | |||
| spec=ServerlessSpec(cloud="aws", region="us-east-1"), | |||
| deletion_protection="disabled", # Defaults to "enabled" | |||
There was a problem hiding this comment.
The default behavior is deletion_protection="disabled" So this comment is incorrect.
There was a problem hiding this comment.
Eek, silly oversight. Thank you!
| @@ -21,15 +21,12 @@ disallow_untyped_defs = "True" | |||
| [tool.poetry.dependencies] | |||
| python = ">=3.9,<3.13" | |||
| langchain-core = "^0.3.15" | |||
| pinecone-client = "^5.0.0" | |||
| pinecone = ">=5.4.0" | |||
There was a problem hiding this comment.
This should be "^5.4.0". >=5.4.0 would include future breaking changes which may not be compatible.
Poetry docs have a nice explanation of how these various syntax elements in version numbers are interpreted. https://python-poetry.org/docs/dependency-specification/
There was a problem hiding this comment.
Ah thank you so much!
| headers={ | ||
| "Api-Key": self.pinecone_api_key.get_secret_value(), | ||
| "Content-Type": "application/json", | ||
| "X-Pinecone-API-Version": "2024-07", |
There was a problem hiding this comment.
You should probably update this API version header while you're here.
This PR updates the Pinecone client to
5.4.0, as well as its dependencies (pinecone-plugin-inferenceandpinecone-plugin-interface).Note:
pinecone-clientis now simply calledpinecone.Question for reviewer(s): should this PR also update the
pineconedep in the root dir'spoetry.lockfile? Was unsure. (I don't believe so b/c it seems pinned to a lower version likely based on 3rd-party deps (e.g. Unstructured).)--
TW: @audrey_sage_