Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LangChain cli fix a few bugs #11573

Merged
merged 1 commit into from
Oct 9, 2023
Merged

LangChain cli fix a few bugs #11573

merged 1 commit into from
Oct 9, 2023

Conversation

eyurtsev
Copy link
Collaborator

@eyurtsev eyurtsev commented Oct 9, 2023

Code was assuming that git and poetry exist. In addition, it was not ignoring pycache files that get generated during run time

@vercel
Copy link

vercel bot commented Oct 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2023 7:09pm

@dosubot dosubot bot added the 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature label Oct 9, 2023
@eyurtsev eyurtsev requested a review from efriis October 9, 2023 19:10
Copy link
Member

@efriis efriis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@efriis efriis added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Oct 9, 2023
@efriis efriis merged commit ca2eed3 into master Oct 9, 2023
@efriis efriis deleted the eugene/more_fixes_for_cli branch October 9, 2023 20:30
hoanq1811 pushed a commit to hoanq1811/langchain that referenced this pull request Feb 2, 2024
Code was assuming that `git` and `poetry` exist. In addition, it was not
ignoring pycache files that get generated during run time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature lgtm PR looks good. Use to confirm that a PR is ready for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants