Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leia not compatible with Chai@5 #37

Closed
tobybellwood opened this issue Jan 24, 2024 · 1 comment · Fixed by #42
Closed

Leia not compatible with Chai@5 #37

tobybellwood opened this issue Jan 24, 2024 · 1 comment · Fixed by #42
Labels
bug Something isn't working

Comments

@tobybellwood
Copy link

tobybellwood commented Jan 24, 2024

Chai 5.0.0 is ESM-only (https://github.com/chaijs/chai/releases/tag/v5.0.0) - so the way that Leia creates the func.js files will need to be altered depending on the version of chai installed.

For now, I've pinned our one-liner to chai4, but it's probably something to look at
yarn add leia-parser mocha chai@4 command-line-test

@tobybellwood tobybellwood added the bug Something isn't working label Jan 24, 2024
@pirog
Copy link
Member

pirog commented Mar 14, 2024

@tobybellwood makes sense. i think we probably want to have leia write the test files using the version of chai it ships with as opposed to letting the user override it with their own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants