feat: add project transaction operation for pylance sdk #3538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review @yanghua @westonpace |
wjones127
reviewed
Mar 12, 2025
python/python/lance/dataset.py
Outdated
Comment on lines
2997
to
3006
| schema: LanceSchema | pa.Schema | ||
|
|
||
| def __post_init__(self): | ||
| if isinstance(self.schema, pa.Schema): | ||
| warnings.warn( | ||
| "Passing a pyarrow.Schema to Project is deprecated. " | ||
| "Please use a LanceSchema instead.", | ||
| DeprecationWarning, | ||
| ) | ||
| self.schema = LanceSchema.from_pyarrow(self.schema) |
There was a problem hiding this comment.
Why create brand new APIs that are deprecated?
Suggested change
| schema: LanceSchema | pa.Schema | |
| def __post_init__(self): | |
| if isinstance(self.schema, pa.Schema): | |
| warnings.warn( | |
| "Passing a pyarrow.Schema to Project is deprecated. " | |
| "Please use a LanceSchema instead.", | |
| DeprecationWarning, | |
| ) | |
| self.schema = LanceSchema.from_pyarrow(self.schema) | |
| schema: LanceSchema |
There was a problem hiding this comment.
OK, I removed the pa.schema support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3537