Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: suppress humantime advisory #3529

Merged
merged 2 commits into from
Mar 12, 2025

Conversation

westonpace
Copy link
Contributor

The humantime package is no longer maintained. We should move to avoid using it. We were using it indirectly via env_logger and object_store. This PR updates env_logger to the latest version (which uses jiff instead of humantime).

object_store is one of our core dependencies and we generally update it as new versions are released. If (and when) humantime is replaced with jiff we will remove the dependency then. This may be several months. apache/arrow-rs#7261 can be used for tracking.

Until then we should suppress the advisory.

@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.81%. Comparing base (422c38d) to head (c978491).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3529      +/-   ##
==========================================
+ Coverage   78.77%   78.81%   +0.03%     
==========================================
  Files         254      254              
  Lines       95423    95423              
  Branches    95423    95423              
==========================================
+ Hits        75168    75204      +36     
+ Misses      17147    17108      -39     
- Partials     3108     3111       +3     
Flag Coverage Δ
unittests 78.81% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@westonpace westonpace force-pushed the chore/ignore-humantime-advisory branch from 76511c5 to c978491 Compare March 11, 2025 22:26
@westonpace westonpace merged commit 53bd796 into lancedb:main Mar 12, 2025
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants