feat: add file writer option for python sdk #3523
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45436a2 to
37d9992
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3523 +/- ##
==========================================
+ Coverage 78.79% 78.81% +0.01%
==========================================
Files 254 254
Lines 95423 95434 +11
Branches 95423 95434 +11
==========================================
+ Hits 75192 75216 +24
+ Misses 17121 17110 -11
+ Partials 3110 3108 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wjones127
reviewed
Mar 12, 2025
Comment on lines
+3730
to
+3731
| Extra file write options that make sense to control lance data file. This is | ||
| used to set page size for file in disk. |
There was a problem hiding this comment.
You should probably document somewhere what the keys are.
There was a problem hiding this comment.
fine. I will add docs and tests after resolved the ci issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.