Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add gcp token-based auth support #3511

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

alex766
Copy link
Contributor

@alex766 alex766 commented Mar 5, 2025

Allow support of connecting to GCP with storage tokens instead of service key JSON or serialized key using object_store's with_credentials.

Tested and created dataset in GCP:
Screenshot 2025-03-05 at 6 24 40 PM
through notebook:
Screenshot 2025-03-05 at 6 42 39 PM

Copy link

github-actions bot commented Mar 5, 2025

ACTION NEEDED
Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.66%. Comparing base (949c6e7) to head (b733219).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
rust/lance-io/src/object_store.rs 63.63% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3511      +/-   ##
==========================================
+ Coverage   78.46%   78.66%   +0.20%     
==========================================
  Files         252      254       +2     
  Lines       93917    94999    +1082     
  Branches    93917    94999    +1082     
==========================================
+ Hits        73692    74731    +1039     
- Misses      17230    17249      +19     
- Partials     2995     3019      +24     
Flag Coverage Δ
unittests 78.66% <63.63%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added the python label Mar 5, 2025
@alex766 alex766 force-pushed the gcp-storage-token-v-0-21-0 branch from 3b4153b to c66d048 Compare March 6, 2025 00:01
@alex766 alex766 changed the title Add gcp token support (v0.21.0) feat: add gcp token-based auth support Mar 6, 2025
@github-actions github-actions bot added the enhancement New feature or request label Mar 6, 2025
@alex766 alex766 force-pushed the gcp-storage-token-v-0-21-0 branch from c66d048 to 1a18b8d Compare March 6, 2025 00:10
@changhiskhan changhiskhan merged commit 644213b into lancedb:main Mar 6, 2025
27 checks passed
alex766 added a commit to alex766/lance that referenced this pull request Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants