Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for empty structs to the 2.0 format #3499

Merged
merged 2 commits into from
Mar 3, 2025

Conversation

westonpace
Copy link
Contributor

No description provided.

@github-actions github-actions bot added enhancement New feature or request python labels Mar 2, 2025
@westonpace westonpace requested a review from BubbleCal March 2, 2025 16:47
@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2025

Codecov Report

Attention: Patch coverage is 89.65517% with 9 lines in your changes missing coverage. Please review.

Project coverage is 78.41%. Comparing base (9211330) to head (532d745).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...ust/lance-encoding/src/encodings/logical/struct.rs 86.76% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3499      +/-   ##
==========================================
+ Coverage   78.40%   78.41%   +0.01%     
==========================================
  Files         252      252              
  Lines       93931    94011      +80     
  Branches    93931    94011      +80     
==========================================
+ Hits        73642    73715      +73     
- Misses      17295    17305      +10     
+ Partials     2994     2991       -3     
Flag Coverage Δ
unittests 78.41% <89.65%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BubbleCal BubbleCal merged commit 33ae43b into lancedb:main Mar 3, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants