Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add with_new_children implementations for several nodes #3471

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

westonpace
Copy link
Contributor

Some of these nodes don't have children (and so I think we thought with_new_children wouldn't be called on them). Others were simply missing an implementation.

These missing impls are causing errors when trying to use lance as a table provider in lancedb.

@github-actions github-actions bot added the enhancement New feature or request label Feb 24, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 44 lines in your changes missing coverage. Please review.

Project coverage is 78.70%. Comparing base (c69a5a2) to head (b74d3f4).

Files with missing lines Patch % Lines
rust/lance/src/io/exec/scalar_index.rs 0.00% 22 Missing ⚠️
rust/lance/src/io/exec/rowids.rs 0.00% 10 Missing ⚠️
rust/lance/src/io/exec/knn.rs 0.00% 6 Missing ⚠️
rust/lance/src/io/exec/pushdown_scan.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3471      +/-   ##
==========================================
- Coverage   78.72%   78.70%   -0.02%     
==========================================
  Files         251      251              
  Lines       92983    93018      +35     
  Branches    92983    93018      +35     
==========================================
+ Hits        73198    73211      +13     
- Misses      16811    16830      +19     
- Partials     2974     2977       +3     
Flag Coverage Δ
unittests 78.70% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@westonpace westonpace merged commit b185a27 into lancedb:main Feb 24, 2025
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants