Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: temporarily disable spilling when training indices on string columns #3469

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

westonpace
Copy link
Contributor

Until we upgrade to the next DF release (46) we cannot rely on spilling when working with string data. Users continue to get errors unrelated to the size of the spill pool or the amount of data they have. This disables spilling entirely on string columns (which is the typical workaround) until we get a stable solution.

@github-actions github-actions bot added the bug Something isn't working label Feb 21, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.73%. Comparing base (c69a5a2) to head (cf34530).

Files with missing lines Patch % Lines
rust/lance/src/index/scalar.rs 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3469      +/-   ##
==========================================
+ Coverage   78.72%   78.73%   +0.01%     
==========================================
  Files         251      251              
  Lines       92983    92995      +12     
  Branches    92983    92995      +12     
==========================================
+ Hits        73198    73223      +25     
+ Misses      16811    16795      -16     
- Partials     2974     2977       +3     
Flag Coverage Δ
unittests 78.73% <92.85%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@westonpace westonpace force-pushed the fix/temp-disable-string-spill branch from a4aa77c to cf34530 Compare February 24, 2025 14:42
@westonpace westonpace merged commit db5281c into lancedb:main Feb 24, 2025
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants