Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose specifying scanner filters via datafusion #3458

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

westonpace
Copy link
Contributor

We are trying to build a Datafusion table provider in LanceDB and it receives expressions as DF logical exprs. We can go DF expr -> substrait -> DF expr but it seems simpler to just expose the API to accept filters as DF exprs directly.

@westonpace
Copy link
Contributor Author

Example usage: lancedb/lancedb#2128

@github-actions github-actions bot added the enhancement New feature or request label Feb 17, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.84%. Comparing base (6b58bc1) to head (2e9ed6e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3458      +/-   ##
==========================================
+ Coverage   78.80%   78.84%   +0.03%     
==========================================
  Files         251      251              
  Lines       92834    92834              
  Branches    92834    92834              
==========================================
+ Hits        73159    73193      +34     
+ Misses      16699    16666      -33     
+ Partials     2976     2975       -1     
Flag Coverage Δ
unittests 78.84% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@westonpace westonpace merged commit 4a0fb90 into lancedb:main Feb 18, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants