Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: implement with_new_children for FTS #3441

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

BubbleCal
Copy link
Contributor

@BubbleCal BubbleCal commented Feb 11, 2025

this method isn't implemented before this and it causes panic, we don't actually need this but maybe some optimizing would call this method for rewriting the plans

Signed-off-by: BubbleCal <bubble-cal@outlook.com>
@github-actions github-actions bot added the bug Something isn't working label Feb 11, 2025
@BubbleCal BubbleCal marked this pull request as ready for review February 11, 2025 04:11
Copy link
Contributor

@eddyxu eddyxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BubbleCal BubbleCal merged commit 2e2bf1a into lancedb:main Feb 11, 2025
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants