Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support fp16 type in SQ #3417

Merged
merged 3 commits into from
Jan 26, 2025
Merged

fix: support fp16 type in SQ #3417

merged 3 commits into from
Jan 26, 2025

Conversation

chebbyChefNEQ
Copy link
Contributor

dynamically check for query type before quantizing to SQ codes

@chebbyChefNEQ chebbyChefNEQ marked this pull request as ready for review January 26, 2025 19:15
@github-actions github-actions bot added the bug Something isn't working label Jan 26, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2025

Codecov Report

Attention: Patch coverage is 11.11111% with 16 lines in your changes missing coverage. Please review.

Project coverage is 78.82%. Comparing base (5a92d31) to head (e21d06d).

Files with missing lines Patch % Lines
rust/lance/src/io/exec/knn.rs 0.00% 14 Missing ⚠️
rust/lance-index/src/vector/sq/storage.rs 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3417      +/-   ##
==========================================
+ Coverage   78.77%   78.82%   +0.04%     
==========================================
  Files         250      250              
  Lines       91304    91306       +2     
  Branches    91304    91306       +2     
==========================================
+ Hits        71929    71974      +45     
+ Misses      16417    16378      -39     
+ Partials     2958     2954       -4     
Flag Coverage Δ
unittests 78.82% <11.11%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chebbyChefNEQ chebbyChefNEQ merged commit 58c5e27 into main Jan 26, 2025
30 checks passed
@chebbyChefNEQ chebbyChefNEQ deleted the rmeng/fix-sq branch January 26, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants