Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: skip shuffling if there is only 1 partition #3405

Merged
merged 7 commits into from
Jan 23, 2025

Conversation

BubbleCal
Copy link
Contributor

No description provided.

Signed-off-by: BubbleCal <bubble-cal@outlook.com>
@BubbleCal BubbleCal marked this pull request as ready for review January 22, 2025 11:47
@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 13.79310% with 25 lines in your changes missing coverage. Please review.

Project coverage is 78.71%. Comparing base (3c82243) to head (6284595).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
rust/lance-index/src/vector/v3/shuffler.rs 12.00% 22 Missing ⚠️
rust/lance-io/src/object_store.rs 0.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3405      +/-   ##
==========================================
- Coverage   78.71%   78.71%   -0.01%     
==========================================
  Files         250      250              
  Lines       90879    90899      +20     
  Branches    90879    90899      +20     
==========================================
+ Hits        71536    71550      +14     
- Misses      16397    16404       +7     
+ Partials     2946     2945       -1     
Flag Coverage Δ
unittests 78.71% <13.79%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: BubbleCal <bubble-cal@outlook.com>
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
@BubbleCal BubbleCal merged commit aae351b into lancedb:main Jan 23, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants