Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flat FTS would return all unindexed rows #3386

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

BubbleCal
Copy link
Contributor

No description provided.

Signed-off-by: BubbleCal <bubble-cal@outlook.com>
@github-actions github-actions bot added the bug Something isn't working label Jan 15, 2025
@BubbleCal BubbleCal marked this pull request as ready for review January 15, 2025 07:48
@BubbleCal BubbleCal requested a review from westonpace January 15, 2025 07:48
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 88.34951% with 12 lines in your changes missing coverage. Please review.

Project coverage is 78.49%. Comparing base (b572905) to head (abb5950).

Files with missing lines Patch % Lines
rust/lance/src/index.rs 89.24% 0 Missing and 10 partials ⚠️
rust/lance-index/src/scalar/inverted/index.rs 80.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3386    +/-   ##
========================================
  Coverage   78.49%   78.49%            
========================================
  Files         250      250            
  Lines       90243    90343   +100     
  Branches    90243    90343   +100     
========================================
+ Hits        70833    70913    +80     
- Misses      16505    16514     +9     
- Partials     2905     2916    +11     
Flag Coverage Δ
unittests 78.49% <88.34%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BubbleCal BubbleCal merged commit bd04392 into lancedb:main Jan 15, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants