fix: handle deletions in take #3360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanghua
reviewed
Jan 8, 2025
yanghua
reviewed
Jan 9, 2025
| } | ||
| } | ||
|
|
||
| pub fn map_offset(&mut self, offset: u32) -> u32 { |
There was a problem hiding this comment.
I see we also have a judgment in fragement.rs here (but missed the judgment of discrete offset). Can we find one way to converge these judgments into one place?
There was a problem hiding this comment.
I could probably re-implement that other function in terms of this one, if we wanted. Though not sure if it is worth while.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not properly handling deletions when mapping raw offsets to row addresses. This PR makes sure we use the deletion files to figure out the exact row addresses.
Fixes #3332