Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add README.md for java module #3302

Merged
merged 4 commits into from
Feb 28, 2025
Merged

docs: add README.md for java module #3302

merged 4 commits into from
Feb 28, 2025

Conversation

yanghua
Copy link
Collaborator

@yanghua yanghua commented Dec 27, 2024

No description provided.

@github-actions github-actions bot added documentation Improvements or additions to documentation java labels Dec 27, 2024
@yanghua
Copy link
Collaborator Author

yanghua commented Dec 27, 2024

Hi, @wjones127 Merry Christmas! Wish you have a nice holiday.

I drafted a previewable outline. Can you give some suggestions when you have time?

westonpace
westonpace reviewed Jan 2, 2025
View reviewed changes
Copy link
Contributor

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good starting point

@yanghua yanghua marked this pull request as ready for review February 11, 2025 00:49
@yanghua yanghua requested a review from SaintBacchus February 11, 2025 00:49
SaintBacchus
SaintBacchus reviewed Feb 18, 2025
View reviewed changes
Copy link
Collaborator

@SaintBacchus SaintBacchus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can let DeepSeek check the English spelling and grammar issues in the document for conveniences.

@yanghua
Copy link
Collaborator Author

yanghua commented Feb 18, 2025

I think we can let DeepSeek check the English spelling and grammar issues in the document for conveniences.

Good suggestion.

@yanghua
Copy link
Collaborator Author

yanghua commented Feb 27, 2025

Hi @SaintBacchus I fixed your review concerns. Please take a look, again. Thanks.

SaintBacchus
SaintBacchus approved these changes Feb 27, 2025
View reviewed changes
Copy link
Collaborator

@SaintBacchus SaintBacchus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanghua yanghua merged commit 7f91eb0 into lancedb:main Feb 28, 2025
7 of 8 checks passed
@yanghua yanghua mentioned this pull request Feb 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonpace westonpace westonpace left review comments

@SaintBacchus SaintBacchus SaintBacchus approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yanghua @westonpace @SaintBacchus